Codecov Report

Merging #265 (a401900) into master (8be8390) will increase coverage by 1.40%.
The diff coverage is 70.00%.

@@             Coverage Diff              @@
##             master     #265      +/-   ##
============================================
+ Coverage     59.70%   61.10%   +1.40%     
- Complexity     1377     1516     +139     
============================================
  Files           166      186      +20     
  Lines          8916     9408     +492     
  Branches        853      918      +65     
============================================
+ Hits           5323     5749     +426     
- Misses         3318     3355      +37     
- Partials        275      304      +29     

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Please cc, just a minor change. @jerqi

Could you give me a concrete example? Why do we need this pr?

Because this static class is currently in LowestIOSampleCostSelectStorageStrategy, but AppBalanceSelectStorageStrategy will also use it, and other selection strategy may use it later, it will be common to set it as a normal class. In addition, sorting is required when selecting the optimal storage path. Sorting depends on this object. If other storage needs to rely on this RankValue, and more comparative attributes need to be added, it will be clearer to define these attributes in a separate class. WDYT ? @jerqi

Why do we migrate RankValue to the package of the common class if shuffle server and client won't use RankValue.

I see what you mean, but I think it is necessary to set it as a separate class. Put it under the coordinator package ？

I see what you mean, but I think it is necessary to set it as a separate class. Put it under the coordinator package ？

Coordinator package is better.

@smallzhongfeng Will you continue this pr?

@smallzhongfeng Will you continue this pr?

Done, sorry to take so long.